snazy commented on PR #1990: URL: https://github.com/apache/polaris/pull/1990#issuecomment-3047689705
The overall concern I raised in #780 is that the low-level persistence model depends on higher-level public API types. So this change to remove the direct dependencies from the persistence model types is a good first step towards decoupling it. @dimas-b's comment, AFAIU was that the `EntityConverter` should live in a package in or near the public API code. Refactoring the code base wrt Gradle modules wasn't explicitly being asked in #780. But that's a way bigger effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
