dimas-b commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2192457575
##########
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##########
@@ -341,9 +342,12 @@ public QuarkusAuthenticationRealmConfiguration
realmAuthConfig(
@Produces
public ActiveRolesProvider activeRolesProvider(
- @ConfigProperty(name = "polaris.active-roles-provider.type") String
activeRolesProviderType,
+ @ConfigProperty(name = "polaris.active-roles-provider.type")
+ Optional<String> deprecatedActiveRolesProviderType,
+ QuarkusAuthenticationRealmConfiguration config,
@Any Instance<ActiveRolesProvider> activeRolesProviders) {
- return
activeRolesProviders.select(Identifier.Literal.of(activeRolesProviderType)).get();
+ String type =
deprecatedActiveRolesProviderType.orElse(config.activeRolesProvider().type());
Review Comment:
nit: it might be possible to do this fallback in `application.properties`,
something like (not tested):
```
polaris.active-roles-provider.type=default
polaris.authentication.active-roles-provider.type=${polaris.active-roles-provider.type}
```
This way feels a bit smoother to me, but it's not critical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
