eric-maynard commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2193907919
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -71,21 +76,23 @@ public AwsStorageConfigurationInfo(
@JsonProperty(value = "externalId") @Nullable String externalId,
@JsonProperty(value = "region", required = false) @Nullable String
region,
@JsonProperty(value = "endpoint") @Nullable String endpoint,
- @JsonProperty(value = "stsEndpoint") @Nullable String stsEndpoint) {
+ @JsonProperty(value = "stsEndpoint") @Nullable String stsEndpoint,
+ @JsonProperty(value = "pathStyleAccess") @Nullable Boolean
pathStyleAccess) {
super(storageType, allowedLocations);
this.roleARN = roleARN;
this.externalId = externalId;
this.region = region;
this.endpoint = endpoint;
this.stsEndpoint = stsEndpoint;
+ this.pathStyleAccess = Optional.ofNullable(pathStyleAccess).orElse(false);
Review Comment:
I'm a huge `Optional` booster, but this is not any shorter than a ternary
expression. More importantly though, I think it would make sense to have a
`PATH_STYLE_ACCESS_DEFAULT` or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
