XN137 commented on issue #463:
URL: https://github.com/apache/polaris/issues/463#issuecomment-3051935405

   what is the latest status on this issue?
   are there any known/agreed upon work items that will help move this forward?
   
   one sub-area i am wondering about is the `CallContext.getCurrentContext()` 
usage in `TaskEntity`.
   it seems its only needed because `PolarisObjectMapperUtil` is using 
`PolarisCallContext.getDiagServices()` to log json-related errors.
   
   since in [other persistence-related 
places](https://github.com/apache/polaris/blob/9ff2ca195aa07f3f150cf25eb2db71074129d212/polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisBaseEntity.java#L124-L127)
 we are simply wrapping the exception in a `IllegalStateException` i am 
wondering whether the need to go through `PolarisDiagnostics` is really so 
strong as to justify the `getCurrentContext()` usage?
   
   even if we wanted to keep the reliance on `PolarisDiagnostics` despite its 
costs, i am wondering whether the `PolarisDiagnostics` instance needs to be 
decided on a per-call basis compared to having a single `PolarisDiagnostics` 
instance configured once per application?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to