MonkeyCanCode commented on code in PR #1995: URL: https://github.com/apache/polaris/pull/1995#discussion_r2196264260
########## client/python/Makefile: ########## @@ -15,10 +15,65 @@ # specific language governing permissions and limitations # under the License. -regenerate-client: +# .SILENT: + +# Configures the shell for recipes to use bash, enabling bash commands and ensuring +# that recipes exit on any command failure (including within pipes). +SHELL = /usr/bin/env bash -o pipefail +.SHELLFLAGS = -ec + +# Version information +VERSION ?= $(shell cat pyproject.toml | grep version | sed 's/version *= *"\(.*\)"/\1/') +BUILD_DATE := $(shell date -u +"%Y-%m-%dT%H:%M:%S%:z") +GIT_COMMIT := $(shell git rev-parse HEAD) +POETRY_VERSION := $(shell cat pyproject.toml | grep requires-poetry | sed 's/requires-poetry *= *"\(.*\)"/\1/') Review Comment: So I did thought about this, there are couple reasons on why I did the above: There are 3 places where we are specify poetry (README.md within this direction...which we said >2.0 will work), regretest (which we defined a specific version, in this case 2.1.3), and pyproject.toml where we said anything >= 2.1 should work. I had updated all 3 pieces to be the same version. Please take another look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
