adutra commented on code in PR #2028: URL: https://github.com/apache/polaris/pull/2028#discussion_r2200691125
########## run.sh: ########## @@ -1,67 +0,0 @@ -#!/bin/bash - -# -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. -# - -# Runs Polaris as a mini-deployment locally. Creates two pods that bind themselves to port 8181. - -# Function to display usage information -usage() { - echo "Usage: $0 [--eclipse-link-deps=<deps>] [-h|--help]" - echo " -h, --help Display this help message" - exit 1 -} - -# Parse command-line arguments -while [[ "$#" -gt 0 ]]; do - case $1 in - -h|--help) - usage - ;; - *) - usage - ;; - esac - shift -done - -# Deploy the registry -echo "Building Kind Registry..." Review Comment: Instead of deleting this file, shouldn't we just adapt it to minikube? I think this script can be useful for people trying out Polaris for the first time, wdyt? ########## run.sh: ########## @@ -1,67 +0,0 @@ -#!/bin/bash - -# -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. -# - -# Runs Polaris as a mini-deployment locally. Creates two pods that bind themselves to port 8181. - -# Function to display usage information -usage() { - echo "Usage: $0 [--eclipse-link-deps=<deps>] [-h|--help]" - echo " -h, --help Display this help message" - exit 1 -} - -# Parse command-line arguments -while [[ "$#" -gt 0 ]]; do - case $1 in - -h|--help) - usage - ;; - *) - usage - ;; - esac - shift -done - -# Deploy the registry -echo "Building Kind Registry..." -sh ./kind-registry.sh - -# Build and deploy the server image -echo "Building polaris image..." -./gradlew \ - :polaris-server:assemble \ - :polaris-server:quarkusAppPartsBuild --rerun \ - :polaris-admin:assemble \ - :polaris-admin:quarkusAppPartsBuild --rerun \ - -Dquarkus.container-image.tag=postgres-latest \ - -Dquarkus.container-image.build=true \ - -Dquarkus.container-image.registry=localhost:5001 - -echo "Pushing polaris image..." -docker push localhost:5001/apache/polaris - -echo "Loading polaris image to kind..." -kind load docker-image localhost:5001/apache/polaris:latest - -echo "Applying kubernetes manifests..." -kubectl delete -f k8/deployment.yaml --ignore-not-found Review Comment: Also, here we could instead install the Helm chart with a simple deployment using in-memory persistence, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
