adutra commented on code in PR #1593:
URL: https://github.com/apache/polaris/pull/1593#discussion_r2203488488


##########
.github/workflows/nightly.yml:
##########
@@ -61,3 +61,27 @@ jobs:
         env:
           ORG_GRADLE_PROJECT_apacheUsername: ${{ secrets.NEXUS_USER }}
           ORG_GRADLE_PROJECT_apachePassword: ${{ secrets.NEXUS_PW }} 
+      - name: Publish Server Docker nightly image
+        run: |
+          ./gradlew \
+            :polaris-server:assemble \
+            :polaris-server:quarkusAppPartsBuild --rerun \
+            -Dquarkus.container-image.build=true \
+            -Dquarkus.container-image.push=true \
+            -Dquarkus.container-image.name=polaris \
+            -Dquarkus.container-image.tag=$(date +%Y%m%d) \
+            -Dquarkus.container-image.additional-tags="" \

Review Comment:
   If the repository + image name are the same as the ones used for releases, 
it's safer to _not_ use `latest` for nightlies.
   
   I recall this ML discussion:
   
   https://lists.apache.org/thread/nr4bw27zyfsr0cc0cn34h1yq0d1t01f7
   
   There wasn't a formal consensus there, but the emerging idea would be to use 
the `nightly` tag, rather than a timestamp, to avoid accumulation of tags.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to