adam-christian-software commented on PR #2123: URL: https://github.com/apache/polaris/pull/2123#issuecomment-3080022527
Hey, @eric-maynard. I agree with you and I think we should revert. Here's what I'd recommend: 1. Revert the PR 2. It would be REALLY cool if we could have a test, so we could have blocked this pre-merge. Either, you could write that PR or we could file an item for it. 3. Robert fixes up the pagination PR (I think it's late his time so he's probably off right now), so we don't regress this. 4. Stepping back, it seems like we have some implicit norms about when a revert is appropriate versus when we should fix forward given the comments. I think it'd be interesting to chat about in our next community sync, so we could figure out what our community norms are going to be. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
