MonkeyCanCode commented on code in PR #2127:
URL: https://github.com/apache/polaris/pull/2127#discussion_r2213848168
##########
client/python/cli/command/catalogs.py:
##########
@@ -64,6 +64,9 @@ class CatalogsCommand(Command):
remove_properties: List[str]
hadoop_warehouse: str
iceberg_remote_catalog_name: str
+ endpoint: str
Review Comment:
Here is the current implementation:
```
def _has_aws_storage_info(self):
return self.role_arn or self.external_id or self.user_arn or
self.region
```
which check the essential stuff. Those 3 are optionals I think, thus we
don't need them here right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
