MonkeyCanCode commented on PR #2049: URL: https://github.com/apache/polaris/pull/2049#issuecomment-3095020162
> Thanks @MonkeyCanCode for working on this! It's great to make python client a package. One small question to confirm, at this stage users will still need to run `./gradlew regeneratePythonClient` before `pip install`? > > I once had an experimental [PR](https://github.com/apache/polaris/pull/1885) to use poetry's custom build file to auto-generate the open api client code when building the package. But I did not have time to fix all the CI for that PR. Do you think that could be the next step of the python packaging? So the bash script polaris already does it. Also, I added those to the new Makefile PR for adding python client related operations in. But yes, if that is more preferred, I can update poetry to do so as opposed to using an external bash script for those. But ideally, people should be using pip install Polaris from a python repo instead. From the changes introduced in this PR, those generated files will be included. Let me know which route is more preferred. @HonahX -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
