MonkeyCanCode commented on code in PR #2143:
URL: https://github.com/apache/polaris/pull/2143#discussion_r2219619429
##########
client/templates/regenerate.sh:
##########
@@ -20,6 +20,8 @@
set -e
+[[ -z ${DOCKER} ]] && DOCKER="$(which podman > /dev/null && echo podman ||
echo docker)"
Review Comment:
so `DOCKER` here refs to the variable name used in the Makefile as well as
those script to change (people can use this variable to set to podman etc. in
the current Makefile, I am using `CONTAINER_TOOL` as oppose to `DOCKER` to
avoid confusion). But from the other PR with @snazy, podman is more preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
