XN137 commented on code in PR #2148:
URL: https://github.com/apache/polaris/pull/2148#discussion_r2221350678
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisEntityManager.java:
##########
@@ -40,39 +39,28 @@
*/
public class PolarisEntityManager {
private final PolarisMetaStoreManager metaStoreManager;
- private final EntityCache entityCache;
+ private final ResolverFactory resolverFactory;
// Lazily instantiated only a single time per entity manager.
private ResolvedPolarisEntity implicitResolvedRootContainerEntity = null;
/**
* @param metaStoreManager the metastore manager for the current realm
- * @param entityCache the entity cache to use (it may be {@code null}).
+ * @param resolverFactory the resolver factor to use
*/
public PolarisEntityManager(
- @Nonnull PolarisMetaStoreManager metaStoreManager, @Nullable EntityCache
entityCache) {
+ @Nonnull PolarisMetaStoreManager metaStoreManager, @Nonnull
ResolverFactory resolverFactory) {
Review Comment:
while i agree that assuming non-null would be the best default it would seem
weird to have only 1 of the parameters annotated like that.
also it would be unjustified to remove the annotation from the 1st parameter
as part of this PR, so i add it to the 2nd parameter for consistency.
long term we should starting using
https://jspecify.dev/docs/applying/#2-add-nullmarked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
