MonkeyCanCode commented on code in PR #2154:
URL: https://github.com/apache/polaris/pull/2154#discussion_r2224255394
##########
client/python/cli/options/parser.py:
##########
@@ -57,22 +57,24 @@ class Parser(object):
),
Argument(Arguments.PROFILE, str, hint="profile for token-based
authentication"),
Argument(Arguments.PROXY, str, hint="proxy URL"),
+ Argument(Arguments.DEBUG, bool, hint="Enable debug mode"),
Review Comment:
so looking at implementing the dry-run mode, it turns out a bit more work
will be needed. For example, for a single update principal property request, it
will need to run following requests:
1. get principal
2. update principal
Now as there is no native way (as far as I know) to do this dry-run, we will
then need to do another monkey patching on the urlopen. Now the challenge is as
a single CLI request will be convert to multiple actual API requests, we will
then need to create proper mock responses for each of the request to move
forward until we hit the last one.
If this is the feature we would like to support (and no other better
solution other than doing a bunch mock responses), I can proceed with those
implementation. The only catch that I can think off is later on if we changed
API on diff version, we will need to keep those up to date (e.g. have mock for
v1 and v2 as they may have diff response etc.). Unlike the debug mode, where we
are really just enrich the output but showing request/header/body.
Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
