XN137 commented on code in PR #2164: URL: https://github.com/apache/polaris/pull/2164#discussion_r2225615390
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisObjectMapperUtil.java: ########## @@ -20,98 +20,19 @@ import com.fasterxml.jackson.core.JsonFactory; import com.fasterxml.jackson.core.JsonParser; -import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.core.JsonToken; -import com.fasterxml.jackson.core.type.TypeReference; -import com.fasterxml.jackson.databind.DeserializationFeature; -import com.fasterxml.jackson.databind.JsonMappingException; -import com.fasterxml.jackson.databind.ObjectMapper; import jakarta.annotation.Nullable; import java.io.IOException; -import java.util.Map; -import org.apache.iceberg.rest.RESTSerializers; -import org.apache.polaris.core.PolarisCallContext; import org.apache.polaris.core.entity.PolarisBaseEntity; import org.apache.polaris.core.entity.PolarisTaskConstants; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -/** A mapper to serialize/deserialize polaris objects. */ -public class PolarisObjectMapperUtil { +public final class PolarisObjectMapperUtil { Review Comment: if we go forward with this PR we might want to rename this class as it now only deals with task (execution) state? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org