rahil-c commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2225964378
##########
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##########
@@ -263,25 +279,39 @@ public String[][] listNamespaces(String[] namespace)
throws NoSuchNamespaceExcep
@Override
public Map<String, String> loadNamespaceMetadata(String[] namespace)
throws NoSuchNamespaceException {
- return this.icebergsSparkCatalog.loadNamespaceMetadata(namespace);
+ Map<String, String> metadata =
this.icebergsSparkCatalog.loadNamespaceMetadata(namespace);
+ if (PolarisCatalogUtils.isHudiExtensionEnabled()) {
+ HudiCatalogUtils.loadNamespaceMetadata(namespace, metadata);
+ }
+ return metadata;
}
@Override
public void createNamespace(String[] namespace, Map<String, String> metadata)
throws NamespaceAlreadyExistsException {
this.icebergsSparkCatalog.createNamespace(namespace, metadata);
+ if (PolarisCatalogUtils.isHudiExtensionEnabled()) {
+ HudiCatalogUtils.createNamespace(namespace, metadata);
+ }
}
@Override
public void alterNamespace(String[] namespace, NamespaceChange... changes)
throws NoSuchNamespaceException {
this.icebergsSparkCatalog.alterNamespace(namespace, changes);
+ if (PolarisCatalogUtils.isHudiExtensionEnabled()) {
+ HudiCatalogUtils.alterNamespace(namespace, changes);
Review Comment:
@gh-yzou @eric-maynard Have followed the recommendation above to remove
namespace-related changes, this should be resolved now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
