pingtimeout commented on code in PR #2179:
URL: https://github.com/apache/polaris/pull/2179#discussion_r2241965005


##########
site/content/release-guide.md:
##########
@@ -188,18 +198,55 @@ cd polaris-dist-dev
 mkdir x.y.z
 cp /path/to/polaris/github/clone/repo/build/distribution/* x.y.z
 cp 
/path/to/polaris/github/clone/repo/runtime/distribution/build/distributions/* 
x.y.z
-cp -r /path/to/polaris/github/clone/repo/helm/polaris helm-chart/x.y.z 
 svn add x.y.z
+```
+
+### Stage Helm Chart package
+
+You can now create a Helm package with the following command in the Polaris 
source folder:
+
+```
+cd helm
+helm package --sign --key '<YOUR KEY ID HERE>' --keyring ~/.gnupg/secring.kbx 
polaris

Review Comment:
   How far do we want to go on the gpg-setup side of things?  Like, should we 
assume (from the prerequisites) that a maintainer has properly configured and 
published their GPG keys?  Or should we include a howto in this guide?
   
   Personally, I would keep this guide as focused as possible on the release 
and assume it is the responsibility of the maintainer to have a properly 
configured identity.  Which means that we could replace this command by:
   
   ```suggestion
   helm package polaris
   helm gpg sign polaris-x.y.z.tgz
   ```
   
   wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to