XN137 commented on code in PR #2248:
URL: https://github.com/apache/polaris/pull/2248#discussion_r2251093276
##########
service/common/src/testFixtures/java/org/apache/polaris/service/TestServices.java:
##########
@@ -147,7 +149,6 @@ public Builder stsClient(StsClient stsClient) {
public TestServices build() {
PolarisConfigurationStore configurationStore = new
MockedConfigurationStore(config);
- PolarisDiagnostics polarisDiagnostics =
Mockito.mock(PolarisDiagnostics.class);
Review Comment:
wondering:
should we annotate `PolarisDiagnostics` with
https://errorprone.info/api/latest/com/google/errorprone/annotations/DoNotMock.html
?
currently there are no legitimate cases for mocking it in the codebase it
seems (but there could be in the future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
