adutra commented on PR #2241: URL: https://github.com/apache/polaris/pull/2241#issuecomment-3151044054
> Honestly, I'm a bit confused. Looking at the only production code call site `o.a.p.service.storage.PolarisStorageIntegrationProviderImpl#PolarisStorageIntegrationProviderImpl(o.a.p.service.storage.StorageConfiguration, o.a.p.core.storage.aws.StsClientProvider)` (an application-scoped bean), it seems the GCP access token is only ever created once? Yes 😅 I think the idea is that these are long-lived credentials for the server itself. But I agree that this is likely not ideal. We'd need something similar to `StsClientProvider`. This PR doesn't change this though, it just introduces the injected `Clock`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
