adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251844836


##########
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##########
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
   public void testFullExceptionIsLogged(
       ExceptionMapper<Exception> mapper, Exception exception, Level level) {
     Logger logger = (Logger) LoggerFactory.getLogger(mapper.getClass());
+    logger.setLevel(level);

Review Comment:
   This test is brittle because it assumes that the logger has the tested level 
enabled, but this is not the case anymore.
   
   Anyways, this test is not very Quarkus-friendly. I will refactor it later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to