fivetran-arunsuri commented on code in PR #2197:
URL: https://github.com/apache/polaris/pull/2197#discussion_r2252725901
##########
spec/polaris-management-service.yml:
##########
@@ -1227,6 +1263,22 @@ components:
- currentEntityVersion
- properties
+ ResetPrincipalRequest:
+ type: object
+ properties:
+ clientId:
+ type: string
+ description: Optional client ID to set for the principal.
+ minLength: 16
+ maxLength: 16
Review Comment:
Thanks for the feedback — I understand your point about keeping
implementation concerns out of the API definition.
The reason I added minLength: and maxLength: was to make the expected
format of clientId and clientSecret clear to API consumers, since these
credentials are generated and validated with a fixed length on our side.
That said, if we prefer to enforce this strictly at the implementation
level, I’m happy to remove the constraints from the API definition and document
the expectations separately. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
