eric-maynard commented on code in PR #2294:
URL: https://github.com/apache/polaris/pull/2294#discussion_r2274142378
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##########
@@ -122,27 +131,58 @@ public void addTaskHandlerContext(long taskEntityId,
CallContext callContext) {
// the task is still running.
// Note: PolarisCallContext has request-scoped beans as well, and must be
cloned.
// FIXME replace with context propagation?
- CallContext clone = callContext.copy();
- tryHandleTask(taskEntityId, clone, null, 1);
+ tryHandleTask(taskEntityId, new TaskContext(callContext), null, 1);
+ }
+
+ record TaskContext(String realmId, PolarisDiagnostics diagnostics) {
Review Comment:
> I mean, sure? There are tests in the code base for this.
Our task tests are not very complete right now, so this doesn't give me much
confidence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
