adutra commented on code in PR #2307: URL: https://github.com/apache/polaris/pull/2307#discussion_r2276369644
########## polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisPrincipal.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.auth; + +import java.security.Principal; +import java.util.Map; +import java.util.Set; +import org.apache.polaris.core.entity.PrincipalEntity; +import org.apache.polaris.immutables.PolarisImmutable; + +/** Represents a {@link Principal} in the Polaris system. */ +@PolarisImmutable +public interface PolarisPrincipal extends Principal { + + /** + * Creates a new instance of {@link PolarisPrincipal} from the given {@link PrincipalEntity} and + * roles. + * + * <p>The created principal will have the same ID and name as the {@link PrincipalEntity}, and its + * properties will be derived from the internal properties of the entity. + * + * @param principalEntity the principal entity representing the user or service + * @param roles the set of roles associated with the principal + */ + static PolarisPrincipal of(PrincipalEntity principalEntity, Set<String> roles) { + return of( + principalEntity.getId(), + principalEntity.getName(), + principalEntity.getInternalPropertiesAsMap(), + roles); + } + + /** + * Creates a new instance of {@link PolarisPrincipal} with the specified ID, name, roles, and + * properties. + * + * @param id the unique identifier of the principal + * @param name the name of the principal + * @param properties additional properties associated with the principal + * @param roles the set of roles associated with the principal + */ + static PolarisPrincipal of( + long id, String name, Map<String, String> properties, Set<String> roles) { + return ImmutablePolarisPrincipal.builder() + .id(id) + .name(name) + .properties(properties) + .roles(roles) + .build(); + } + + /** + * Returns the unique identifier of the principal. + * + * <p>This identifier is used to uniquely identify the principal within a Polaris realm. + */ + long getId(); Review Comment: The problem is that the Resolver requires the principal to have an id, since it resolves principals by id. Thus it seemed to me that it was legit to require from all principals to have at least a numeric identifier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
