dennishuo commented on code in PR #2190:
URL: https://github.com/apache/polaris/pull/2190#discussion_r2277253883
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -64,22 +66,29 @@ public abstract class ConnectionConfigInfoDpo implements
IcebergCatalogPropertie
// The authentication parameters for the connection
private final AuthenticationParametersDpo authenticationParameters;
+ // The Polaris service identity info of the connection
+ private final ServiceIdentityInfoDpo serviceIdentity;
+
public ConnectionConfigInfoDpo(
@JsonProperty(value = "connectionTypeCode", required = true) int
connectionTypeCode,
@JsonProperty(value = "uri", required = true) @Nonnull String uri,
@JsonProperty(value = "authenticationParameters", required = true)
@Nonnull
- AuthenticationParametersDpo authenticationParameters) {
- this(connectionTypeCode, uri, authenticationParameters, true);
+ AuthenticationParametersDpo authenticationParameters,
+ @JsonProperty(value = "serviceIdentity", required = false) @Nonnull
+ ServiceIdentityInfoDpo serviceIdentity) {
+ this(connectionTypeCode, uri, authenticationParameters, serviceIdentity,
true);
}
protected ConnectionConfigInfoDpo(
int connectionTypeCode,
@Nonnull String uri,
@Nonnull AuthenticationParametersDpo authenticationParameters,
+ @Nonnull ServiceIdentityInfoDpo serviceIdentity,
Review Comment:
Is this actually `@Nullable`? Here and above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
