XN137 commented on code in PR #2229:
URL: https://github.com/apache/polaris/pull/2229#discussion_r2278527819
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BaseMetaStoreManager.java:
##########
@@ -53,6 +56,16 @@ public static PolarisStorageConfigurationInfo
extractStorageConfiguration(
return PolarisStorageConfigurationInfo.deserialize(storageConfigInfoStr);
}
+ private final Supplier<MS> metaStoreSupplier;
+
+ public BaseMetaStoreManager(Supplier<MS> metaStoreSupplier) {
+ this.metaStoreSupplier = Suppliers.memoize(metaStoreSupplier::get);
Review Comment:
as per my comment this is still WIP and i am figuring out the actual
lifetime of the `BasePersistence` object.
if what you are saying is true and the currently suggested change would
break an existing contract, how is it that no test in CI is failing?
can you help adding a test that covers this contract explicitly?
or at least describe how such a test would need to look like?
that would help a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
