dimas-b commented on code in PR #2339:
URL: https://github.com/apache/polaris/pull/2339#discussion_r2279788376
##########
client/python/cli/command/catalogs.py:
##########
@@ -121,18 +122,17 @@ def validate(self):
f"
{Argument.to_flag_name(Arguments.CATALOG_SERVICE_IDENTITY_IAM_ARN)}")
if self.storage_type == StorageType.S3.value:
- if not self.role_arn:
- raise Exception(
- f"Missing required argument for storage type 's3':"
- f" {Argument.to_flag_name(Arguments.ROLE_ARN)}"
- )
if self._has_azure_storage_info() or self._has_gcs_storage_info():
raise Exception(
f"Storage type 's3' supports the storage credentials"
f" {Argument.to_flag_name(Arguments.ROLE_ARN)},"
f" {Argument.to_flag_name(Arguments.REGION)},"
- f" {Argument.to_flag_name(Arguments.EXTERNAL_ID)}, and"
- f" {Argument.to_flag_name(Arguments.USER_ARN)}"
+ f" {Argument.to_flag_name(Arguments.EXTERNAL_ID)},"
+ f" {Argument.to_flag_name(Arguments.USER_ARN)},"
+ f" {Argument.to_flag_name(Arguments.ENDPOINT)},"
+ f" {Argument.to_flag_name(Arguments.ENDPOINT_INTERNAL)},"
+ f" {Argument.to_flag_name(Arguments.STS_ENDPOINT)}, and"
+ f" {Argument.to_flag_name(Arguments.PATH_STYLE_ACCESS)}"
Review Comment:
Perhaps the message on line 127 (`Storage type 's3' supports the storage
credentials`) needs to be adjusted now that we have non-credential options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
