jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2281535465
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -420,16 +423,45 @@ public Response loadTable(
.loadTableIfStale(tableIdentifier, ifNoneMatch, snapshots)
.orElseThrow(() -> new
WebApplicationException(Response.Status.NOT_MODIFIED));
} else {
- response =
+ LoadTableResponse originalResponse =
catalog
.loadTableWithAccessDelegationIfStale(tableIdentifier,
ifNoneMatch, snapshots)
.orElseThrow(() -> new
WebApplicationException(Response.Status.NOT_MODIFIED));
+
+ if (delegationModes.contains(VENDED_CREDENTIALS)) {
+ response =
+ injectRefreshVendedCredentialProperties(
+ originalResponse,
+ new
PolarisResourcePaths(prefix).credentialsPath(tableIdentifier));
+ } else {
+ response = originalResponse;
+ }
}
return tryInsertETagHeader(Response.ok(response), response,
namespace, table).build();
});
}
+ private LoadTableResponse injectRefreshVendedCredentialProperties(
+ LoadTableResponse originalResponse, String credentialsEndpoint) {
+ LoadTableResponse.Builder loadResponseBuilder =
+
LoadTableResponse.builder().withTableMetadata(originalResponse.tableMetadata());
+ loadResponseBuilder.addAllConfig(originalResponse.config());
+ loadResponseBuilder.addAllCredentials(originalResponse.credentials());
+ loadResponseBuilder.addConfig(
Review Comment:
I assumed it's the same properties. I think it's not a good choice to use
different properties, even if the client level has different settings. The
protocol with the server should be standard. However, it seems like that boat
has sailed.
Would you like me to avoid the injection code if refresh is disabled. I
still prefer returning it to the user (I'm a power user kind of developer) but
I'll remove it if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
