pingtimeout commented on code in PR #2375: URL: https://github.com/apache/polaris/pull/2375#discussion_r2282315106
########## gradle/libs.versions.toml: ########## @@ -22,6 +22,7 @@ checkstyle = "10.25.0" hadoop = "3.4.1" iceberg = "1.9.2" # Ensure to update the iceberg version in regtests to keep regtests up-to-date quarkus = "3.25.0" +s3mock = "4.7.0" Review Comment: +1. I would reserve the usage of version variables for groups of dependencies (e.g. quarkus deps). For S3Mock, given that there is a single dependency, this indirection is not necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
