adutra commented on code in PR #2380:
URL: https://github.com/apache/polaris/pull/2380#discussion_r2285738680
##########
helm/polaris/values.yaml:
##########
@@ -62,6 +62,21 @@ podLabels: {}
# -- Additional Labels to apply to polaris configmap.
configMapLabels: {}
+# -- Pod disruption budget settings.
+podDisruptionBudget:
+ # -- Specifies whether a pod disruption budget should be created.
+ enabled: false
+ # -- The minimum number of pods that should remain available during
disruptions.
+ # Can be an absolute number (ex: 5) or a percentage of desired pods (ex:
50%).
+ # Cannot be used if maxUnavailable is set.
+ minAvailable: ~
+ # -- The maximum number of pods that can be unavailable during disruptions.
+ # Can be an absolute number (ex: 5) or a percentage of desired pods (ex:
50%).
+ # Cannot be used if minAvailable is set.
+ maxUnavailable: 1
Review Comment:
Setting this to 1 by default forces users to unset this value, if they want
to set `minAvailable`. How about we don't specify any default value for any of
the fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
