MonkeyCanCode opened a new pull request, #2439: URL: https://github.com/apache/polaris/pull/2439
This PR fixed couple things: 1. Remove docs generation from openapi (previously discussed in https://github.com/apache/polaris/pull/2192 with @HonahX). For this one, 2. Remove stderr (which is not action-able ATM. see sample output 1 below) 3. Remove __pycache__ output (which is not action-able ATM. see sample output 2 below) 4. Skip test generation (which is also not being used ATM) 5. Use logger and add verbose mode for `generate_clients.py` Previous sample outputs: ``` Sample output 1: [main] ERROR o.o.codegen.DefaultCodegen - Required var format-version not in properties [main] ERROR o.o.codegen.DefaultCodegen - Required var schema not in properties [main] ERROR o.o.codegen.DefaultCodegen - Required var schema not in properties [main] ERROR o.o.codegen.DefaultCodegen - Required var schema-id not in properties [main] ERROR o.o.codegen.DefaultCodegen - Required var schema-id not in properties Sample output 2: polaris/catalog/models/__pycache__/assert_table_uuid.cpython-313.pyc: skipped (path excluded) polaris/catalog/models/__pycache__/partition_spec.cpython-313.pyc: skipped (path excluded) polaris/catalog/models/__pycache__/value_map.cpython-313.pyc: skipped (path excluded) polaris/catalog/models/__pycache__/table_identifier.cpython-313.pyc: skipped (path excluded) polaris/catalog/models/__pycache__/list_tables_response.cpython-313.pyc: skipped (path excluded) polaris/catalog/models/__pycache__/data_file.cpython-313.pyc: skipped (path excluded) polaris/catalog/models/__pycache__/set_expression.cpython-313.pyc: skipped (path excluded) ``` Here is the new sample output: ``` ➜ polaris git:(client_openapi_fix) make client-regenerate Installing Poetry and project dependencies into .venv... Requirement already satisfied: pip in ./.venv/lib/python3.13/site-packages (25.2) Installing dependencies from lock file No dependencies to install or update Installing the current project: polaris (1.0.0)Preparing build environment with build-system requirements poetry-core>=2.0.0,<3.0.0 Deleting old tests... Old test deletion complete. Re-applying license headers... License fix complete. Installing the current project: polaris (1.0.0) Poetry and dependencies installed. --- Regenerating client code --- Deleting old tests... Old test deletion complete. Re-applying license headers... License fix complete. --- Client code regeneration complete --- ``` If we need to debug, we can then use the `verbose` flag (currently not supported within Makefile as we don't support `verbose` mode for any other commands atm (if we think this can be handy, we can add this): ``` polaris git:(client_openapi_fix) source .venv/bin/activate && cd client/python && python3 -B generate_clients.py -v Deleting old tests... test/test_cli_parsing.py: skipped Old test deletion complete. Re-applying license headers... generate_clients.py: skipped (path excluded) .pre-commit-config.yaml: skipped (path excluded) .openapi-generator-ignore: skipped (path excluded) pyproject.toml: skipped (path excluded) README.md: skipped (path excluded) .gitignore: skipped (extension excluded) docker-compose.yml: skipped (path excluded) poetry.lock: skipped (path excluded) test/test_cli_parsing.py: skipped (path excluded) integration_tests/conftest.py: skipped (path excluded) integration_tests/test_catalog_apis.py: skipped (path excluded) integration_tests/test_management_apis.py: skipped (path excluded) cli/constants.py: skipped (path excluded) cli/__init__.py: skipped (path excluded) cli/polaris_cli.py: skipped (path excluded) polaris/__init__.py: updated polaris/.keep: skipped (extension excluded) .openapi-generator/VERSION: skipped (path excluded) .openapi-generator/FILES: skipped (path excluded) polaris/catalog/configuration.py: updated polaris/catalog/rest.py: updated polaris/catalog/__init__.py: updated polaris/catalog/.keep: skipped (extension excluded) polaris/catalog/api_response.py: updated polaris/catalog/py.typed: updated polaris/catalog/exceptions.py: updated polaris/catalog/api_client.py: updated polaris/management/configuration.py: updated polaris/management/rest.py: updated polaris/management/__init__.py: updated polaris/management/.keep: skipped (extension excluded) polaris/management/api_response.py: updated polaris/management/py.typed: updated polaris/management/exceptions.py: updated polaris/management/api_client.py: updated polaris/management/models/catalog.py: updated polaris/management/models/bearer_authentication_parameters.py: updated polaris/management/models/o_auth_client_credentials_parameters.py: updated polaris/management/models/table_grant.py: updated polaris/management/models/principal_with_credentials.py: updated polaris/management/models/view_grant.py: updated polaris/management/models/principal_role.py: updated polaris/management/models/create_principal_role_request.py: updated polaris/management/models/catalog_properties.py: updated polaris/management/models/principal.py: updated polaris/management/models/sig_v4_authentication_parameters.py: updated polaris/management/models/external_catalog.py: updated polaris/management/models/aws_iam_service_identity_info.py: updated polaris/management/models/authentication_parameters.py: updated polaris/management/models/update_catalog_role_request.py: updated polaris/management/models/gcp_storage_config_info.py: updated polaris/management/models/file_storage_config_info.py: updated polaris/management/models/catalog_roles.py: updated polaris/management/models/create_catalog_request.py: updated polaris/management/models/namespace_grant.py: updated polaris/management/models/hadoop_connection_config_info.py: updated polaris/management/models/catalogs.py: updated polaris/management/models/create_catalog_role_request.py: updated polaris/management/models/update_principal_role_request.py: updated polaris/management/models/catalog_privilege.py: updated polaris/management/models/polaris_catalog.py: updated polaris/management/models/principals.py: updated polaris/management/models/add_grant_request.py: updated polaris/management/models/aws_storage_config_info.py: updated polaris/management/models/__init__.py: updated polaris/management/models/.keep: skipped (extension excluded) polaris/management/models/catalog_role.py: updated polaris/management/models/policy_privilege.py: updated polaris/management/models/connection_config_info.py: updated polaris/management/models/create_principal_request.py: updated polaris/management/models/implicit_authentication_parameters.py: updated polaris/management/models/update_principal_request.py: updated polaris/management/models/principal_roles.py: updated polaris/management/models/grant_resource.py: updated polaris/management/models/azure_storage_config_info.py: updated polaris/management/models/view_privilege.py: updated polaris/management/models/hive_connection_config_info.py: updated polaris/management/models/grant_resources.py: updated polaris/management/models/iceberg_rest_connection_config_info.py: updated polaris/management/models/grant_principal_role_request.py: updated polaris/management/models/service_identity_info.py: updated polaris/management/models/namespace_privilege.py: updated polaris/management/models/storage_config_info.py: updated polaris/management/models/update_catalog_request.py: updated polaris/management/models/principal_with_credentials_credentials.py: updated polaris/management/models/revoke_grant_request.py: updated polaris/management/models/table_privilege.py: updated polaris/management/models/policy_grant.py: updated polaris/management/models/grant_catalog_role_request.py: updated polaris/management/models/catalog_grant.py: updated polaris/management/api/__init__.py: updated polaris/management/api/.keep: skipped (extension excluded) polaris/management/api/polaris_default_api.py: updated polaris/catalog/models/base_update.py: updated polaris/catalog/models/set_statistics_update.py: updated polaris/catalog/models/policy_attachment_target.py: updated polaris/catalog/models/struct_field.py: updated polaris/catalog/models/remove_snapshots_update.py: updated polaris/catalog/models/load_generic_table_response.py: updated polaris/catalog/models/transform_term.py: updated polaris/catalog/models/delete_file.py: updated polaris/catalog/models/sort_order.py: updated polaris/catalog/models/scan_tasks.py: updated polaris/catalog/models/counter_result.py: updated polaris/catalog/models/assign_uuid_update.py: updated polaris/catalog/models/scan_report.py: updated polaris/catalog/models/completed_planning_result.py: updated polaris/catalog/models/plan_table_scan_request.py: updated polaris/catalog/models/report_metrics_request.py: updated polaris/catalog/models/partition_spec.py: updated polaris/catalog/models/iceberg_error_response1.py: updated polaris/catalog/models/metadata_log_inner.py: updated polaris/catalog/models/partition_statistics_file.py: updated polaris/catalog/models/list_policies_response.py: updated polaris/catalog/models/commit_table_request.py: updated polaris/catalog/models/completed_planning_with_id_result.py: updated polaris/catalog/models/error_model.py: updated polaris/catalog/models/load_policy_response.py: updated polaris/catalog/models/partition_field.py: updated polaris/catalog/models/load_table_result.py: updated polaris/catalog/models/timer_result.py: updated polaris/catalog/models/null_order.py: updated polaris/catalog/models/statistics_file.py: updated polaris/catalog/models/notification_request.py: updated polaris/catalog/models/view_requirement.py: updated polaris/catalog/models/assert_create.py: updated polaris/catalog/models/assert_default_spec_id.py: updated polaris/catalog/models/struct_type.py: updated polaris/catalog/models/snapshot_log_inner.py: updated polaris/catalog/models/get_applicable_policies_response.py: updated polaris/catalog/models/sort_direction.py: updated polaris/catalog/models/commit_table_response.py: updated polaris/catalog/models/sql_view_representation.py: updated polaris/catalog/models/set_partition_statistics_update.py: updated polaris/catalog/models/term.py: updated polaris/catalog/models/primitive_type_value.py: updated polaris/catalog/models/create_table_request.py: updated polaris/catalog/models/position_delete_file.py: updated polaris/catalog/models/remove_statistics_update.py: updated polaris/catalog/models/assert_current_schema_id.py: updated polaris/catalog/models/add_partition_spec_update.py: updated polaris/catalog/models/sort_field.py: updated polaris/catalog/models/create_policy_request.py: updated polaris/catalog/models/commit_report.py: updated polaris/catalog/models/policy.py: updated polaris/catalog/models/fetch_scan_tasks_result.py: updated polaris/catalog/models/view_metadata.py: updated polaris/catalog/models/view_representation.py: updated polaris/catalog/models/catalog_config.py: updated polaris/catalog/models/generic_table.py: updated polaris/catalog/models/table_metadata.py: updated polaris/catalog/models/table_update.py: updated polaris/catalog/models/upgrade_format_version_update.py: updated polaris/catalog/models/add_sort_order_update.py: updated polaris/catalog/models/commit_view_request.py: updated polaris/catalog/models/commit_transaction_request.py: updated polaris/catalog/models/__init__.py: updated polaris/catalog/models/blob_metadata.py: updated polaris/catalog/models/snapshot_reference.py: updated polaris/catalog/models/.keep: skipped (extension excluded) polaris/catalog/models/add_view_version_update.py: updated polaris/catalog/models/type.py: updated polaris/catalog/models/get_namespace_response.py: updated polaris/catalog/models/set_default_spec_update.py: updated polaris/catalog/models/view_version.py: updated polaris/catalog/models/and_or_expression.py: updated polaris/catalog/models/remove_partition_statistics_update.py: updated polaris/catalog/models/assert_view_uuid.py: updated polaris/catalog/models/plan_status.py: updated polaris/catalog/models/table_identifier.py: updated polaris/catalog/models/rename_table_request.py: updated polaris/catalog/models/attach_policy_request.py: updated polaris/catalog/models/remove_properties_update.py: updated polaris/catalog/models/remove_snapshot_ref_update.py: updated polaris/catalog/models/fetch_planning_result.py: updated polaris/catalog/models/enable_row_lineage_update.py: updated polaris/catalog/models/file_scan_task.py: updated polaris/catalog/models/set_snapshot_ref_update.py: updated polaris/catalog/models/add_snapshot_update.py: updated polaris/catalog/models/o_auth_token_response.py: updated polaris/catalog/models/table_update_notification.py: updated polaris/catalog/models/list_generic_tables_response.py: updated polaris/catalog/models/create_namespace_response.py: updated polaris/catalog/models/data_file.py: updated polaris/catalog/models/false_expression.py: updated polaris/catalog/models/remove_partition_specs_update.py: updated polaris/catalog/models/list_tables_response.py: updated polaris/catalog/models/map_type.py: updated polaris/catalog/models/list_namespaces_response.py: updated polaris/catalog/models/not_expression.py: updated polaris/catalog/models/o_auth_error.py: updated polaris/catalog/models/view_update.py: updated polaris/catalog/models/assert_last_assigned_field_id.py: updated polaris/catalog/models/create_view_request.py: updated polaris/catalog/models/file_format.py: updated polaris/catalog/models/create_namespace_request.py: updated polaris/catalog/models/applicable_policy.py: updated polaris/catalog/models/token_type.py: updated polaris/catalog/models/set_current_schema_update.py: updated polaris/catalog/models/iceberg_error_response.py: updated polaris/catalog/models/update_namespace_properties_response.py: updated polaris/catalog/models/empty_planning_result.py: updated polaris/catalog/models/view_history_entry.py: updated polaris/catalog/models/assert_last_assigned_partition_id.py: updated polaris/catalog/models/update_namespace_properties_request.py: updated polaris/catalog/models/set_default_sort_order_update.py: updated polaris/catalog/models/async_planning_result.py: updated polaris/catalog/models/true_expression.py: updated polaris/catalog/models/list_type.py: updated polaris/catalog/models/content_file.py: updated polaris/catalog/models/unary_expression.py: updated polaris/catalog/models/assert_table_uuid.py: updated polaris/catalog/models/assert_default_sort_order_id.py: updated polaris/catalog/models/assert_ref_snapshot_id.py: updated polaris/catalog/models/load_view_result.py: updated polaris/catalog/models/update_policy_request.py: updated polaris/catalog/models/value_map.py: updated polaris/catalog/models/add_schema_update.py: updated polaris/catalog/models/detach_policy_request.py: updated polaris/catalog/models/set_properties_update.py: updated polaris/catalog/models/model_schema.py: updated polaris/catalog/models/fetch_scan_tasks_request.py: updated polaris/catalog/models/expression.py: updated polaris/catalog/models/set_location_update.py: updated polaris/catalog/models/set_current_view_version_update.py: updated polaris/catalog/models/count_map.py: updated polaris/catalog/models/register_table_request.py: updated polaris/catalog/models/metric_result.py: updated polaris/catalog/models/policy_identifier.py: updated polaris/catalog/models/set_expression.py: updated polaris/catalog/models/literal_expression.py: updated polaris/catalog/models/failed_planning_result.py: updated polaris/catalog/models/snapshot.py: updated polaris/catalog/models/plan_table_scan_result.py: updated polaris/catalog/models/equality_delete_file.py: updated polaris/catalog/models/notification_type.py: updated polaris/catalog/models/table_requirement.py: updated polaris/catalog/models/storage_credential.py: updated polaris/catalog/models/create_generic_table_request.py: updated polaris/catalog/models/load_credentials_response.py: updated polaris/catalog/models/snapshot_summary.py: updated polaris/catalog/api/iceberg_o_auth2_api.py: updated polaris/catalog/api/catalog_api.py: updated polaris/catalog/api/generic_table_api.py: updated polaris/catalog/api/__init__.py: updated polaris/catalog/api/.keep: skipped (extension excluded) polaris/catalog/api/iceberg_configuration_api.py: updated polaris/catalog/api/o_auth2_api.py: updated polaris/catalog/api/configuration_api.py: updated polaris/catalog/api/iceberg_catalog_api.py: updated polaris/catalog/api/policy_api.py: updated cli/options/__init__.py: skipped (path excluded) cli/options/parser.py: skipped (path excluded) cli/options/option_tree.py: skipped (path excluded) cli/command/catalog_roles.py: skipped (path excluded) cli/command/catalogs.py: skipped (path excluded) cli/command/principals.py: skipped (path excluded) cli/command/__init__.py: skipped (path excluded) cli/command/principal_roles.py: skipped (path excluded) cli/command/privileges.py: skipped (path excluded) cli/command/profiles.py: skipped (path excluded) cli/command/namespaces.py: skipped (path excluded) License fix complete. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
