MonkeyCanCode commented on issue #2419: URL: https://github.com/apache/polaris/issues/2419#issuecomment-3222428993
> > Thanks [@MonkeyCanCode](https://github.com/MonkeyCanCode) . Could you share these PRs? > > > asking users to specify SCRIPT_DIR doesn't make much sense anymore imo. > > > > > > Agreed. > > I can work on this later tonight then share for removing SCRIPT_DIR. But other than this and the rename of `polaris` script, all other ones that I think we should change are linked in the above. Here is the sample PR: https://github.com/apache/polaris/pull/2448 (basically it contains the changes I have in my original PR when profiles option was introduced: https://github.com/apache/polaris/pull/931/commits/c667139cf3bdeedc0b533868610265bda45923b6) As now people may be using this already, we may need to make it backward compatible by introducing an optional flag to overwrite it. Let run by @eric-maynard and @HonahX on this before I add more code in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
