XN137 commented on code in PR #2415:
URL: https://github.com/apache/polaris/pull/2415#discussion_r2301084876
##########
runtime/service/src/test/java/org/apache/polaris/service/admin/PolarisAdminServiceTest.java:
##########
@@ -52,10 +53,9 @@
import org.mockito.MockitoAnnotations;
public class PolarisAdminServiceTest {
-
+ private PolarisDiagnostics diagnostics = new PolarisDefaultDiagServiceImpl();
@Mock private CallContext callContext;
@Mock private PolarisCallContext polarisCallContext;
- @Mock private PolarisDiagnostics polarisDiagnostics;
Review Comment:
note that this mock would have been silently ignoring any diagnostics errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
