singhpk234 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2301428512


##########
CHANGELOG.md:
##########
@@ -82,7 +82,9 @@ at locations that better optimize for object storage.
 - Introduced bootstrap command options to specify custom schema files for 
database initialization.
 
 - Added refresh credentials endpoint configuration to LoadTableResponse for 
AWS, Azure, and GCP. Enabling
-automatic storage credential refresh per table on the client side.
+automatic storage credential refresh per table on the client side. Java client 
version >= 1.8.0 is required.
+The endpoint path is always returned when using vended credentials, but the 
client must configure 
+REFRESH\_ENDPOINT\_ENABLED = "true" in the catalog properties for the client 
to use the endpoint.

Review Comment:
   the properties are unfortunately different for the all the cloud providers, 
not sure if we wanna call this out, just saying enabled never the less 
`refresh-credentials-enabled` should be endpoint 
   
   how about we say that clients must enable refresh-credentials flag for their 
respective cloud provider ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to