flyrain commented on code in PR #2422:
URL: https://github.com/apache/polaris/pull/2422#discussion_r2301832331
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -508,6 +508,11 @@ private void createNamespaceInternal(
} else {
LOGGER.debug("Skipping location overlap validation for namespace '{}'",
namespace);
}
+ if (!realmConfig.getConfig(
+ FeatureConfiguration.ALLOW_NAMESPACE_CUSTOM_LOCATION, catalogEntity)) {
Review Comment:
Given (1) is the current behavior, I'm fine with the change. We can handle
the case (2) in followup PRs. Can we enrich the description to reduce the
confusing?
```
.description("If set to true, allow namespaces with custom locations.")
```
->
```
.description("If set to true, allow namespaces with custom locations,
which could escape from parent locations, allowed catalog locations. Please be
aware that credential vending may not work in that case.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
