dimas-b commented on code in PR #2445:
URL: https://github.com/apache/polaris/pull/2445#discussion_r2301284493
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -113,6 +114,17 @@ public void warnOnFailedChecks(
}
}
+ @Produces
+ public ProductionReadinessCheck checkMetricTags(MetricsConfiguration config)
{
+ if (config.userPrincipalTag().enableInApiMetrics()) {
+ return ProductionReadinessCheck.of(
+ Error.of(
+ "Metrics configuration includes user principal name in tags.",
Review Comment:
This will effectively always produce WARN log messages in servers where
principal tags are enabled, even if the admin user configured that explicitly.
From my POV this is not ideal user experience, but having this WARN is probably
better that accidentally exposing principal names.
I think we may want to add per-message suppression for production checks at
some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
