adutra commented on code in PR #2480:
URL: https://github.com/apache/polaris/pull/2480#discussion_r2318253912
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -777,8 +777,8 @@ public Response sendNotification(
securityContext,
prefix,
catalog -> {
- catalog.sendNotification(tableIdentifier, notificationRequest);
- return Response.status(Response.Status.NO_CONTENT).build();
+ boolean notificationSent = catalog.sendNotification(tableIdentifier,
notificationRequest);
Review Comment:
Also: `status(Response.Status.NO_CONTENT).entity(notificationSent)` is
contradictory: the response for a 204 status should not contain any body:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
