pingtimeout commented on PR #2383: URL: https://github.com/apache/polaris/pull/2383#issuecomment-3258609812
I compared the list of commands that JB executed for the 1.1.0 release with the ones that would have been executed by the workflow and found the following differences: 1. The release branch is not identical. As per the release guide, it should be `release/1.1.0-incubating`, but the one JB used was `release/1.1.x`, which is probably better, should we want to use that branch to cut new patch releases. 2. JB commands contained a `./gradlew clean build`. This is unnecessary as we can only execute the workflow against a commit which has been verified by CI. 3. JB commands contained a `./gradlew build -x test -x intTest`. In this PR, @snazy pointed out that this is unnecessary and could be replaced by `./gradlew assemble`, which is what the workflow produced 4. The workflow creates two SVN commits on dist/dev: one for the binaries and one for the Helm charts. JB added everything into a single commit. I am going to update the workflows accordingly. 5. JB closed the Nexus repository manually, whereas it _should_ be possible to automate this with `./gradlew closeApacheStagingRepository`, which is what the workflows use. 6. The workflows try to add the `index.yaml` file from the wrong directory. Points (1), (4) and (6) should be fixed. Points (2) and (3) can imo be ignored. @jbonofre may I request you to verify the closeApacheStagingRepository command from point (5) please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
