HonahX commented on code in PR #2544:
URL: https://github.com/apache/polaris/pull/2544#discussion_r2338053994


##########
polaris-core/src/test/java/org/apache/polaris/service/storage/gcp/GcpCredentialsStorageIntegrationTest.java:
##########
@@ -177,6 +177,12 @@ private AccessConfig subscopedCredsForOperations(
         Optional.of(REFRESH_ENDPOINT));
   }
 
+  private JsonNode readResource(ObjectMapper mapper, String name) throws 
IOException {
+    // readTree from a test resource is not affected by the issues that 
prompted its deprecation
+    //noinspection deprecation
+    return 
mapper.readTree(GcpCredentialsStorageIntegrationTest.class.getResource(name));

Review Comment:
   [Non-blocker] For my learning purpose, is there any reason that we want to 
suppress it instead of fixing it by explicitly opening a stream and read the 
stream? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to