fivetran-kostaszoumpatianos commented on code in PR #2472:
URL: https://github.com/apache/polaris/pull/2472#discussion_r2338925947
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -74,7 +74,14 @@ public void warnOnFailedChecks(
@Observes Startup event,
Instance<ProductionReadinessCheck> checks,
ReadinessConfiguration config) {
- List<Error> errors = checks.stream().flatMap(check ->
check.getErrors().stream()).toList();
+ List<Error> errors =
+ checks.stream()
+ .flatMap(check -> check.getErrors().stream())
+ .filter(
+ error ->
+ config.ignoreOffendingProperties().stream()
+ .noneMatch(prop ->
prop.equalsIgnoreCase(error.offendingProperty())))
Review Comment:
Filtering based on error ids would also fit well with the naming change that
you propose @eric-maynard then we can call the ignore method:
`ignoreSelectedIssues` since we will now have a way of filtering by issue.
Maybe the parameter hash is a bit too much, for me I would be ok deactivating a
check altogether if I know that I have a dangerous config there. It depends on
how cautious we want to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
