dimas-b commented on code in PR #2518:
URL: https://github.com/apache/polaris/pull/2518#discussion_r2349714392
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -194,7 +194,7 @@ Page<PolarisBaseEntity> loadEntities(
*/
@Nonnull
CreatePrincipalResult createPrincipal(
- @Nonnull PolarisCallContext callCtx, @Nonnull PolarisBaseEntity
principal);
+ @Nonnull PolarisCallContext callCtx, @Nonnull PrincipalEntity principal);
Review Comment:
+1 to `dev` discussion.
I agree that this change can affect downstream projects. Still, according to
the current [Polaris
Evolution](https://polaris.apache.org/in-dev/unreleased/evolution/#using-polaris-as-a-build-time-dependency)
approach, this kind of java class change is not considered an "API" change
from the SemVer perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
