HonahX commented on code in PR #2580:
URL: https://github.com/apache/polaris/pull/2580#discussion_r2353976797
##########
Makefile:
##########
@@ -162,6 +162,12 @@ client-integration-test: client-setup-env ## Run client
integration tests
@echo "Tearing down Docker Compose services..."
@$(DOCKER) compose -f $(PYTHON_CLIENT_DIR)/docker-compose.yml down ||
true # Ensure teardown even if tests fail
+.PHONY: client-license-check
+client-license-check: client-setup-env ## Run license compliance check
+ @echo "--- Starting license compliance check ---"
+ @$(ACTIVATE_AND_CD) && pip-licenses
Review Comment:
Yeah I ran make install-dependencies and I saw poetry explicitly said it
installed pip-licenses yet it still could not found it. Could be some other
weird issue in that env. So I ends up using a clean environment to verify : )
Using poetry run pip-licenses will work btw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
