dimas-b commented on code in PR #2633:
URL: https://github.com/apache/polaris/pull/2633#discussion_r2363836778
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java:
##########
@@ -193,8 +193,11 @@ static AccessConfig toAccessConfig(
}
private static void handleAzureCredential(
- AccessConfig.Builder config, String sasToken, String host) {
+ AccessConfig.Builder config, String sasToken, String host, Instant
expiresAt) {
config.putCredential(StorageAccessProperty.AZURE_SAS_TOKEN.getPropertyName() +
host, sasToken);
+ config.putCredential(
+
StorageAccessProperty.AZURE_SAS_TOKEN_EXPIRES_AT_MS_PREFIX.getPropertyName() +
host,
Review Comment:
Could you add a test case for this to
`AzureCredentialsStorageIntegrationTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
