singhpk234 commented on code in PR #2650: URL: https://github.com/apache/polaris/pull/2650#discussion_r2369092348
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -122,9 +122,27 @@ polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"] # polaris.persistence.type=eclipse-link # polaris.persistence.type=in-memory-atomic polaris.persistence.type=in-memory -# polaris.persistence.type=relational-jdbc - +#polaris.persistence.type=relational-jdbc polaris.secrets-manager.type=in-memory +#disable localstack +#if set to true it will try to start localstack at build and run time for the local environment +quarkus.devservices.enabled=false + + +#AWS IAM postgres example Review Comment: wondering linking this additionally https://docs.quarkiverse.io/quarkus-amazon-services/dev/amazon-rds.html#_configuration_reference would be helpful too ########## persistence/relational-jdbc/build.gradle.kts: ########## @@ -35,6 +35,9 @@ dependencies { implementation(libs.smallrye.common.annotation) // @Identifier implementation(libs.postgresql) + implementation("software.amazon.awssdk:url-connection-client") Review Comment: why do we need url-connection-client specifically ? can this not work with apache http client ? per this should work - https://docs.quarkiverse.io/quarkus-amazon-services/dev/amazon-rds.html#_configuring_rds_clients ########## runtime/defaults/src/main/resources/application.properties: ########## @@ -122,9 +122,27 @@ polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"] # polaris.persistence.type=eclipse-link # polaris.persistence.type=in-memory-atomic polaris.persistence.type=in-memory -# polaris.persistence.type=relational-jdbc - +#polaris.persistence.type=relational-jdbc polaris.secrets-manager.type=in-memory +#disable localstack +#if set to true it will try to start localstack at build and run time for the local environment +quarkus.devservices.enabled=false + + +#AWS IAM postgres example +#quarkus.datasource.jdbc.url=jdbc:postgresql://aurora-cluster-url:6160/polaris +#quarkus.datasource.jdbc.additional-jdbc-properties.wrapperPlugins=iam +#quarkus.datasource.username=dbusername +#quarkus.datasource.active=true +#quarkus.datasource.db-kind=postgresql +#quarkus.datasource.jdbc.additional-jdbc-properties.ssl=true +#quarkus.datasource.jdbc.additional-jdbc-properties.sslmode=require +#quarkus.datasource.credentials-provider=aws + +#quarkus.rds.credentials-provider.aws.use-quarkus-client="true" +#quarkus.rds.credentials-provider.aws.username=dbusername Review Comment: seems like this is from this section - https://docs.quarkiverse.io/quarkus-amazon-services/dev/amazon-rds.html#_iam_authentication_support_with_quarkus_credential_provider ? did you had to change the trust relationships etc and IAM policy etc, would be helpful adding something about that here too ! wondering if we can move this to https://polaris.apache.org/in-dev/unreleased/metastores/ ? cc @flyrain @dimas-b thoughts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
