eric-maynard commented on code in PR #2643:
URL: https://github.com/apache/polaris/pull/2643#discussion_r2369595047
##########
client/python/cli/polaris_cli.py:
##########
@@ -67,8 +55,10 @@ def execute(args=None):
command = Command.from_options(options)
command.execute()
else:
- client_builder = PolarisCli._get_client_builder(options)
- with client_builder() as api_client:
+ client_builder = ApiClientBuilder(
+ options,
direct_authentication=PolarisCli.DIRECT_AUTHENTICATION_ENABLED
+ )
+ with client_builder.build() as api_client:
Review Comment:
Since we immediately call `build` I wonder if we really need the factory
pattern here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
