HonahX opened a new pull request, #2673:
URL: https://github.com/apache/polaris/pull/2673
<!--
Possible security vulnerabilities: STOP here and contact
[email protected] instead!
Please update the title of the PR with a meaningful message - do not
leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in
this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly
hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in
site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
This was based on @poojanilangekar 's great work:
https://github.com/apache/polaris/pull/2223 and fix some small issues
identified there.
Quote from original PR:
> This PR creates missing synthetic entities for securables in external
passthrough catalogs.
Based on Option 1 discussed in the [RBAC section of this
doc.](https://docs.google.com/document/d/19Vm0Uy-EyEYtgd2-bZpPICODOB3rYQJvHeqL1ODOOLc/edit?tab=t.0#heading=h.w1wfe5hhumyt)
> In the future, we could remove calls to PolarisEntity.Builder() and
replace them with entities fetched from the remote catalog. (enabling Option 2).
> Testing:
Unit test primarily based on mocking path resolution and the metastore API.
I've synced with @poojanilangekar offline to merge the basic changes first
and collaborate on other changes in follow-ups.
Please see all related discussions in the original PR:
https://github.com/apache/polaris/pull/2223
cc: @poojanilangekar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
