adutra commented on code in PR #2634:
URL: https://github.com/apache/polaris/pull/2634#discussion_r2380181107
##########
runtime/service/src/main/java/org/apache/polaris/service/auth/internal/service/OAuthError.java:
##########
@@ -16,21 +16,25 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.polaris.service.auth;
-import jakarta.annotation.Nullable;
+package org.apache.polaris.service.auth.internal.service;
-/**
- * This is a union of configuration settings of all token brokers.
- *
- * @see TokenBrokerFactory
- */
-public interface TokenBrokerFactoryConfig {
- @Nullable
- String file();
+public enum OAuthError {
+ invalid_request("The request is invalid"),
Review Comment:
This enum comes from here:
https://github.com/apache/polaris/blob/20febdaede19fb7c46e120652fdd1a262c2138e4/runtime/service/src/main/java/org/apache/polaris/service/auth/OAuthTokenErrorResponse.java#L27-L45
I just renamed to `OAuthError` to avoid the name clash with
`java.lang.Error`.
But otherwise, the enum constants were all lower case (snake case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
