flyrain commented on code in PR #2650: URL: https://github.com/apache/polaris/pull/2650#discussion_r2380485646
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -122,9 +122,29 @@ polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"] # polaris.persistence.type=eclipse-link # polaris.persistence.type=in-memory-atomic polaris.persistence.type=in-memory -# polaris.persistence.type=relational-jdbc - +#polaris.persistence.type=relational-jdbc polaris.secrets-manager.type=in-memory +#disable localstack Review Comment: nit: we usually have a space between `#` and content. ########## runtime/defaults/src/main/resources/application.properties: ########## @@ -122,9 +122,29 @@ polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"] # polaris.persistence.type=eclipse-link # polaris.persistence.type=in-memory-atomic polaris.persistence.type=in-memory -# polaris.persistence.type=relational-jdbc - +#polaris.persistence.type=relational-jdbc Review Comment: minor: this change seems unnecessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
