dimas-b commented on code in PR #2695:
URL: https://github.com/apache/polaris/pull/2695#discussion_r2382775143
##########
site/content/in-dev/unreleased/command-line-interface.md:
##########
@@ -133,8 +133,12 @@ options:
--type The type of catalog to create in [INTERNAL, EXTERNAL]. INTERNAL
by default.
--storage-type (Required) The type of storage to use for the catalog
--default-base-location (Required) Default base location of the catalog
+ --endpoint (Only for S3) The S3 endpoint to use when connecting to S3
+ --endpoint-internal (Only for S3) The S3 endpoint used by Polaris to
use when connecting to S3, if different from the one that clients use
+ --sts-endpoint (Only for S3) The STS endpoint to use when connecting to
STS
+ --path-style-access (Only for S3) Whether to use path-style-access for
S3
--allowed-location An allowed location for files tracked by the
catalog. Multiple locations can be provided by specifying this option more than
once.
- --role-arn (Required for S3) A role ARN to use when connecting to S3
+ --role-arn (Only for S3) A role ARN to use when connecting to S3
Review Comment:
Only for AWS
##########
site/content/in-dev/unreleased/getting-started/creating-a-catalog/s3/_index.md:
##########
@@ -32,7 +32,7 @@ For the `polaris catalogs create` [command]({{% ref
"../../../command-line-inter
```text
--storage-type s3
---role-arn (Required for S3) A role ARN to use when connecting to S3
+--role-arn (Only for S3) A role ARN to use when connecting to S3
Review Comment:
It's required only for AWS. MinIO does not need it. I _guess_ other non-AWS
systems do not need it either.
##########
site/content/in-dev/unreleased/getting-started/using-polaris/keycloak-idp.md:
##########
@@ -48,7 +50,7 @@ Polaris is configured with 3 realms:
issued by both Polaris and Keycloak.
For more information about how to configure Polaris with external
authentication, see the
-[Polaris documentation]({{% ref "../external-idp" %}}).
+[Polaris
documentation](https://polaris.apache.org/in-dev/unreleased/managing-security/external-idp/).
Review Comment:
Can this be a "hugo" `ref`? Docs will be "frozen" after a release to links
to `in-dev` from old versions are likely to become invalid pretty soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
