XJDKC commented on code in PR #2523: URL: https://github.com/apache/polaris/pull/2523#discussion_r2383054603
########## runtime/service/src/main/java/org/apache/polaris/service/identity/registry/DefaultServiceIdentityRegistry.java: ########## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.service.identity.registry; + +import com.google.common.annotations.VisibleForTesting; +import jakarta.inject.Inject; +import java.util.EnumMap; +import java.util.Map; +import java.util.Optional; +import java.util.stream.Collectors; +import org.apache.polaris.core.context.RealmContext; +import org.apache.polaris.core.identity.ServiceIdentityType; +import org.apache.polaris.core.identity.dpo.ServiceIdentityInfoDpo; +import org.apache.polaris.core.identity.registry.ServiceIdentityRegistry; +import org.apache.polaris.core.identity.resolved.ResolvedServiceIdentity; +import org.apache.polaris.core.secrets.ServiceSecretReference; +import org.apache.polaris.service.identity.ServiceIdentityConfiguration; + +/** + * Default implementation of {@link ServiceIdentityRegistry} that resolves service identities from + * statically configured values (typically defined via Quarkus server configuration). + * + * <p>This implementation supports both multi-tenant (e.g., SaaS) and self-managed (single-tenant) + * Polaris deployments: + * + * <ul> + * <li>In multi-tenant mode, each tenant (realm) can have its own set of service identities + * defined in the configuration. The same identity will consistently be assigned for each + * {@link ServiceIdentityType} within a given tenant. + * <li>In single-tenant or self-managed deployments, a single set of service identities can be + * defined and used system-wide. + * </ul> + */ +public class DefaultServiceIdentityRegistry implements ServiceIdentityRegistry { + public static final String DEFAULT_REALM_KEY = ServiceIdentityConfiguration.DEFAULT_REALM_KEY; + public static final String DEFAULT_REALM_NSS = "system:default"; + private static final String IDENTITY_INFO_REFERENCE_URN_FORMAT = + "urn:polaris-secret:default-identity-registry:%s:%s"; + + /** Map of service identity types to their resolved identities. */ + private final EnumMap<ServiceIdentityType, ResolvedServiceIdentity> resolvedServiceIdentities; + + /** Map of identity info references (URNs) to their resolved service identities. */ + private final Map<String, ResolvedServiceIdentity> referenceToResolvedServiceIdentity; + + public DefaultServiceIdentityRegistry() { + this(new EnumMap<>(ServiceIdentityType.class)); + } + + public DefaultServiceIdentityRegistry( + EnumMap<ServiceIdentityType, ResolvedServiceIdentity> serviceIdentities) { + this.resolvedServiceIdentities = serviceIdentities; + this.referenceToResolvedServiceIdentity = + serviceIdentities.values().stream() + .collect( + Collectors.toMap( + identity -> identity.getIdentityInfoReference().getUrn(), + identity -> identity)); + } + + @Inject + public DefaultServiceIdentityRegistry( + RealmContext realmContext, ServiceIdentityConfiguration serviceIdentityConfiguration) { + this.resolvedServiceIdentities = + serviceIdentityConfiguration.resolveServiceIdentities(realmContext).stream() Review Comment: > My point is that the loops in this DefaultServiceIdentityRegistry constructor consider all identity data, while only one of the identities is likely to be requested from each particular instance of DefaultServiceIdentityRegistry. I understand your point 🙂 What I mean is: when resolving the service identity based on a reference, we need to collect all possible service identities and maintain a map where the key is the reference and the value is the actual service identity info. That way, we can look up the identity by reference. (We could optimize this further, e.g., by parsing the URN to extract the key, adding a new interface in the config class and loading only that specific identity, this approach works, but there are some conventions between the config class and the `ServiceIdentityRegistry`, i also don't want to overload the config class). I agree this can feel a bit heavy since we'd be doing the same work for every request. That's why we previously introduced a `ServiceIdentityRegistryFactory` and cached the `RequestScoped` `ServiceIdentityRegistry`: so we don't repeatedly rebuild it. Given that `DefaultServiceIdentityRegistry` is based on static config and won't change at runtime, this caching helps keep things efficient. But like you said, it's a light-weight and in the real prod, we likely won't use the `DefaultServiceIdentityRegistry`, so we should be good. Or we add an official cache for the resolved service identities in OSS polaris. Considering it's not a blocker, I will resolve the conversation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
