XN137 commented on code in PR #2540:
URL: https://github.com/apache/polaris/pull/2540#discussion_r2398239748
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ServiceProducers.java:
##########
@@ -169,6 +142,34 @@ public PolarisAuthorizer polarisAuthorizer(RealmConfig
realmConfig) {
return new PolarisAuthorizerImpl(realmConfig);
}
+ @Produces
+ @RequestScoped
+ public ResolverFactory resolverFactory(
+ PolarisDiagnostics diagnostics,
+ RealmContext realmContext,
+ RealmConfig realmConfig,
+ MetaStoreManagerFactory metaStoreManagerFactory,
+ CallContext callContext,
+ PolarisMetaStoreManager polarisMetaStoreManager) {
+ EntityCache entityCache =
+ metaStoreManagerFactory.getOrCreateEntityCache(realmContext,
realmConfig);
+ return (securityContext, referenceCatalogName) ->
+ new Resolver(
+ diagnostics,
+ callContext.getPolarisCallContext(),
+ polarisMetaStoreManager,
+ securityContext,
+ entityCache,
+ referenceCatalogName);
+ }
+
+ @Produces
+ @RequestScoped
+ public ResolutionManifestFactory resolutionManifestFactory(
+ PolarisDiagnostics diagnostics, RealmContext realmContext,
ResolverFactory resolverFactory) {
+ return new ResolutionManifestFactoryImpl(diagnostics, realmContext,
resolverFactory);
Review Comment:
it's probably not strictly needed, this just keeps the same style the
previous code used.
we can also do it the other way if you prefer.
i'd suggest to do it a followup if its ok with you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
