HonahX commented on code in PR #2736:
URL: https://github.com/apache/polaris/pull/2736#discussion_r2403574783
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -832,13 +836,25 @@ public boolean sendNotification(
PolarisEntitySubType.ICEBERG_TABLE, identifier, notificationRequest);
}
+ /**
+ * Get access configuration for credential vending.
+ *
+ * @deprecated This method couples credential vending logic to the catalog
implementation,
+ * preventing reuse for federated catalogs. Use {@link
AccessConfigProvider#getAccessConfig}
+ * instead, which provides the same functionality as a standalone
factory. This method will be
+ * removed in a future release.
+ * @see AccessConfigProvider
+ */
@Override
+ @Deprecated
public AccessConfig getAccessConfig(
Review Comment:
Sounds good! I think the `instance of` check also only happen once in
`icebergCatalogHandler`. I will remove the method and the interface but leave
this conversation open should anyone notice some downstream dependency on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
